Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[NMP-703]: UI Fertigation Units #710

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

lunamoonmoon
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Change the headings for 'Fertigation Details - Add' page
  • Match 'Total Product Volume per Fertigation' and 'Total Product Volume for Growing Season' to the unit the user selects for product rate
  • Round Volumes to One decimal place, time to the nearest minute (no decimals)
  • Headers for N, P2O5, and K2O need to be aligned and the icons in 'Still Required This Year' should go beside the number totals
  • Change 'Action' header for both Dry Fertilizer and Dry Fertilizer (Custom) to 'Solubility Assessment'
  • Change output text from 'Good' to 'Soluble' and keep the green checkmark

Screenshot 2024-11-28 at 12 11 31 PM

Screenshot 2024-11-27 at 2 35 25 PM

@lunamoonmoon lunamoonmoon linked an issue Nov 28, 2024 that may be closed by this pull request
6 tasks
@PaulGarewal
Copy link
Contributor

Not sure if this is in another ticket, but may be good to get the spell check here of "fetigation" -> "fertigation"
Also should we centre the "Time per Application" header?

@lunamoonmoon
Copy link
Contributor Author

Not sure if this is in another ticket, but may be good to get the spell check here of "fetigation" -> "fertigation" Also should we centre the "Time per Application" header?

Fixed fertigation typo and centered "Time per Application" header.
Screenshot 2024-12-04 at 1 18 53 PM

PaulGarewal
PaulGarewal previously approved these changes Dec 4, 2024
Copy link
Contributor

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@raarielgrace raarielgrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul approved, and I merged w/o making any changes, so I'm re-approving.

@lunamoonmoon lunamoonmoon merged commit 314dbe4 into master Dec 9, 2024
4 checks passed
@lunamoonmoon lunamoonmoon deleted the 703-fertigationheadings branch December 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Headings, Match Units, Rounding Totals, and Action Wording Change
3 participants