As a Reporter, I want to attach a file to my application, so that I can submit production verification statements

[suhafa]

Description:

Issue was identified in CIIP Enhancements Prioritization planning. Context from the session from notes taken by attendees:

"Files will be stored on google cloud storage. CIIP app will contain the metadata related to the file. They want the ability to just download, not upload. Can users delete the file if wrong? (Note: we don't delete). Will need requirements gathering/UI design to better understand what is needed."

There is a matching analyst/download user story: #2181

Acceptance Criteria:

Given I am an industrial reporter
When I am filling out an application
And I am on the "production" tab
Then I can see an optional file upload widget

Given I am an industrial reporter
When I am on the "production" tab
Then I can upload multiple documents

Given I am an industrial reporter
When I am on the "production" tab
And I uploaded one or more documents
Then I can remove these documents from my application version by clicking a delete button

Dev checklist:

• replicate the exact same pattern as done in CIF
• attachment table
• postgraphile similar to CIF: https://github.com/bcgov/cas-cif/blob/develop/app/server/middleware/graphql/uploadFieldPlugin.js
• provisioning buckets for attachments like in cif
• upload component in cif

Wireframe

[LindsayMacfarlane]

Updated priority to Medium based on prioritization session.

[Dianadec]

Need to determine if this is getting iceboxed. To do: discuss with CIIP team @LindsayMacfarlane @pbastia

[pbastia]

The question is - how much value would this feature bring, in regard to the high cost of implementation? Especially given that verification statements are already uploaded to SWRS and retrievable through Metabase.

Maybe a direct link to the right Metabase query to see these attachments could be a good candidate, and would get us close to the required functionality? @LindsayMacfarlane @Dianadec

[pbastia]

Answer:

• This is a new requirement for 2022 tax year
• The verification statement is different from the one submitted in SWRS
• It's more than a 'nice to have' and will avoid the ciip team to handle email communication separately for applications requiring that statement uploaded

[pbastia]

Answer:

• This is a new requirement for 2022 tax year
• The verification statement is different from the one submitted in SWRS
• It's more than a 'nice to have' and will avoid the ciip team to handle email communication separately for applications requiring that statement uploaded

[pbastia]

There could be a few ways of doing this:

• a field on an existing form (maybe products? if it's a production verification statement)
• an extra step in the wizard
• a field just before submitting the application, on the summary form

[pbastia]

Hey team! Please add your planning poker estimate with Zenhub @BCerki @dleard @gurjmatharu @sam-warren @Sepehr-Sobhani @tmastrom

[Sepehr-Sobhani]

Do we have an attachment table to keep the file info or it's part of this card?!

[BCerki]

@suhafa, do you have more information on who's allowed to access/delete these attachments? I assume industry users can do everything including hard delete (correct me if I'm wrong). What are analysts and administrators allowed to do?

[suhafa]

@BCerki I don't have any information on what analysts and admin can do here, tagging @pbastia for any insight he may have for this

[BCerki]

Notes:

• upload middleware: Setting up both batchMiddleware and uploadMiddleware doesn't work relay-tools/react-relay-network-modern#109
• if a user tries to upload the same file twice they'll get an error (db doesn't allow this). The AC doesn't include custom error handling, so I used the "Oops..." default message

[pbastia]

Thanks for the hard work @BCerki ! When I try to upload multiple different attachments, I get the "Oops! ..." message, even if it's not the same file. Is there something I might be doing wrong?

[BCerki]

@pbastia, it's because of a unique index, I added it to this card: #2196

[pbastia]

Thank you @BCerki ! I'll mark this one as completed then :)