Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Industry user (reporter) is missing routes #2605

Closed
2 of 6 tasks
BCerki opened this issue Dec 17, 2024 · 5 comments
Closed
2 of 6 tasks

Industry user (reporter) is missing routes #2605

BCerki opened this issue Dec 17, 2024 · 5 comments
Assignees
Labels

Comments

@BCerki
Copy link
Contributor

BCerki commented Dec 17, 2024

Describe the task

Reporters (industry_user) should be able to do almost all of the same things admins (industry_user_admin) can do (they can't approve people). However, we're missing some routes in the bciers/apps/administration/app/bceidbusiness/industry_user folder (they do exist in bciers/apps/administration/app/bceidbusiness/industry_user_admin). This ticket is about adding those missing routes.

Acceptance Criteria

  • Reporters have all the routes and can access everything according to the miro board about roles
  • Reporters cannot approve admins
  • third

Definition of Done

  • first
  • second
  • third

Additional context

  • Add any other context about the task here.
  • Or here
@BCerki BCerki added the Task label Dec 17, 2024
@BCerki BCerki self-assigned this Jan 9, 2025
@patriciarussellCAS
Copy link

@fviduya this one would be great to have you review before PO sign-off. :)

@fviduya
Copy link
Contributor

fviduya commented Jan 14, 2025

I have tested this and can verify that:

  • Reporters have all the routes and can access everything according to the Miro board user roles
  • Reporters cannot approve admins

I've documented the testing here. I found some stuff that might be worth checking into, which will be created in separate tickets.

@vesselak
Copy link

@patrickisaac please create continuous improvement tickets for the findings on page 6, 13 and 15 that FV recorded. Accepting ticket with this notes.

@patrickisaac
Copy link

@vesselak - I'll review the document Chesca added and create the tickets as requested by EOD tomorrow (Jan. 15, 2025)
cc: @fviduya

@patrickisaac
Copy link

@vesselak - Tickets #2692 and #2693 have been created as continuous improvement items as requested
cc: @fviduya and @patriciarussellCAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants