LCFS - BUG - Other diesel

[airinggov]

Describe the Bug
The label 'Other diesel' should be updated to 'Other diesel fuel'. Additionally, it is currently resolving to 'Prescribed carbon intensity' when it should provide the select options for Default carbon intensity and Fuel codes. The volume is being incorrectly added to Line 1 of the summary instead of Line 2, as 'Other diesel fuel' is a renewable fuel.

Expected Behaviour

• The label should display as 'Other diesel fuel'.
• 'Determining carbon intensity' should provide the select options for Default carbon intensity and Fuel codes
• Volumes should be added to Line 2 of the summary under Diesel. (may already be resolved other card)

Actual Behaviour

• The label shows as 'Other diesel'.
• 'Determining carbon intensity' incorrectly resolves to 'Prescribed carbon intensity'.
• Volumes are incorrectly added to Line 1 of the summary.

Implications

• Incorrect labeling and resolution lead to data misrepresentation.
• Renewable fuel volumes are inaccurately categorized, potentially affecting reporting and compliance calculations.

Steps To Reproduce
User/Role: BCeID user.

1. Navigate to the relevant data entry, Fuel supply, Export fuel, Other use, Allocation agreements
2. Input Fuel type 'Other diesel'.
3. Observe that:
   • The label reads 'Other diesel'.
   • It resolves to 'Prescribed carbon intensity'.
   • Volumes are added to Line 1 of the summary instead of Line 2.

[airinggov]

@areyeslo Hi Arturo, this critical 2 point card has been in progress for 2 weeks, is it near completion?

[areyeslo]

sorry Al in the last 2 weeks I worked just 3 days, and compleated the other tickets in WIP 1540 and 1509. This ticket is the next. I will let you know when it is ready for your review.

[airinggov]

@areyeslo ok thanks, I guess we should make a point that if taking a critical card it can be completed before vacation or else assigned to another dev

[areyeslo]

We have the following scenario:
fuel export & supply of fuel are using get_fuel_supply_options function which includes the following logic:
For non-fossil derived fuels includes ALL provisions where provision of the act is not Prescribed carbon intensity - section 19 (a) for other diesel option. Then, we are showing provision_of_the_act_id = 2 (Fuel code) and provision_of_the_act_id=3 (Default carbon intensity)

allocation agreement has a different logic using ``get_formatted_fuel_typesfunction which is just querying by fuel type =other diesel` and getting the provision_of_the_act_id value in `fuel_type` table which in dev is provision_of_the_act = 1.

To have allocation_agreement with the same logic, we would need to query provision_of_the_act table instead of querying fuel_type.provision_1_id and fuel_type_provision_2_id. The change I attempted to implement is the following in fuel_code/repo.py (get_formatted_fuel_types):

query = (
            select(
                FuelType,
                ProvisionOfTheAct.provision_of_the_act_id,
                ProvisionOfTheAct.name.label("provision_of_the_act"),
            )
            .outerjoin(FuelType.fuel_instances)
            .outerjoin(FuelInstance.fuel_category)
            .outerjoin(FuelType.fuel_codes)
            .outerjoin(
                ProvisionOfTheAct,
                or_(
                    and_(
                        FuelType.fossil_derived == True,
                        ProvisionOfTheAct.provision_of_the_act_id == 1,
                    ),
                    and_(
                        FuelType.fossil_derived == False,
                        ProvisionOfTheAct.provision_of_the_act_id != 1,
                    ),
                ),
            )

However, still getting the record from fuel_type.provision_1_id

[areyeslo]

Created PR for approval:
#1604

Note: January 6th I am off, I will be back on January 7th.

[airinggov]

@areyeslo The two select fields (fuel category & end use) aren't being autoset or giving options to select. Also the CI fields aren't being set. This is on the Fuel supply schedule.

There may be a conflict with card #1545 work with Kevin to resolve.

[areyeslo]

@airinggov going to take a look. the implementation for allocation agreement is using a different function which is isolated from the other schedules. Going to take a look at this.

[areyeslo]

On Dev, I am not getting the behaviour mentioned above (selecting fuel type - Other diesel fuel, auto sets Fuel Category and End use as well as CI of fuel).

Fuel Supply schedule - autoselects fuel category, fuel use and CI of fuel:

Allocation Agreement - autoselects fuel category, fuel use and CI of fuel:

Fuel Export is NOT selecting automatically End use:

Checking this last schedule.

[areyeslo]

These are the PR related in the comments, but there is no affectation between them:
https://github.com/bcgov/lcfs/pull/1587/files
https://github.com/bcgov/lcfs/pull/1604/files

[airinggov]

@areyeslo Yes there was a conversation in Teams that I think addressed these issues through a data reset in dev

[airinggov]

@areyeslo looks great now