Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locality qualifier in locality name is distorting match scores #233

Open
mraross opened this issue Mar 6, 2021 · 4 comments
Open

locality qualifier in locality name is distorting match scores #233

mraross opened this issue Mar 6, 2021 · 4 comments

Comments

@mraross
Copy link

mraross commented Mar 6, 2021

 Johnson BC

scores the same as:

 Johnson Bay Indian Arm, Indian Arm, BC

because

 Johnson BC

is penalized for only making a partial match to:

 Johnson BC near Indian Arm

when, in fact, it is a perfect match to:

 Johnson BC

because:

 near Indian Arm

is just a qualifier and not part of the official locality name.

image.png

Here's the geocoder query:

https://geocoder.api.gov.bc.ca/addresses.xhtml?locationDescriptor=parcelPoint&echo=true&brief=true&minScore=50&maxResults=5&autoComplete=true&matchPrecisionNot=&addressString=Johnson%20bc

@mraross
Copy link
Author

mraross commented Mar 6, 2021

If the localityName (Johnson) and the localityQualifier (near Indian Arm) were kept separate for the purposes of locality name comparison, this situation would be avoided. localityQualifier should be included in match results as well.

@mraross
Copy link
Author

mraross commented Mar 8, 2021

Heres another example:

 Kitsilano

matches the following with the same score and in the order given:

 Kitsilano 6 in Vancouver, BC
 Kitsilano in Vancouver, BC

@BK01
Copy link
Contributor

BK01 commented Nov 18, 2022

Propose adding a zero-point fault for a missing qualifier. The aim is to not penalize or reduce the score of an addressString for a missing locality qualifier, if it is still valid without it.

@BK01 BK01 modified the milestones: Geocoder 4.1.2, Geocoder 4.3 Nov 18, 2022
@BK01
Copy link
Contributor

BK01 commented Dec 13, 2023

Validated in geocodertst (Geocoder 4.3). A zero point penalty is applied as a partial locality match in the examples above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants