Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin App Import does not work. #322

Open
dkelsey opened this issue Sep 1, 2021 · 1 comment
Open

Admin App Import does not work. #322

dkelsey opened this issue Sep 1, 2021 · 1 comment

Comments

@dkelsey
Copy link
Contributor

dkelsey commented Sep 1, 2021

Describe the bug

I used the Import feature to import a revised configuration.
The import claims it is successful.
When I review the parameters I see that nothing has changed.

Note:

  • the comparison feature does work.
  • updating field and persisting them also works correctly

To Reproduce

Steps to reproduce the behavior:

${TEST_ADMIN_ENDPOINT} - the url for the Admin App Endpoint in TEST
${DEV_ADMIN_ENDPOINT} - the url for the Admin App Endpoint in DEV

  1. export a configuration from another environment.
curl -s https://${TEST_ADMIN_ENDPOINT}/int/export >ols-router-data.config.json
  1. Modify the output file in some way so that you can confirm the import succeeds
    I change the dataSource.baseFileUrl to something like 'this is a test'
  2. import the configuration
curl -X POST https://${DEV_ADMIN_ENDPONT}/int/import -F [email protected]

Response:

<!DOCTYPE html>
<html>
  <head>
    <title>OLS Router Admin</title>
    <link href="css/styles.css" rel="stylesheet" type="text/css" />
  </head>
  <body>
    <div class="body">
      <div class="sideBar">
	    <div class="sideNav">
	      <div class="sideMenu">
	        <div class="title">OLS Router Admin</a></div>
		    <ul>
			  <li><a href="params.jsp">Parameter Defaults</a></li>
			  <li><a href="import_export.jsp">Import/Export</a></li>
			  <li><a href="help.jsp">Administration Help</a></li>
			</ul>
	      </div>
	    </div>
	  </div>
      <div class="bodyContainer">
<div class="bodyContent">
<h1>Import Configuration</h1>



  <h2>Import Successful</h2>



	<p><strong>Messages</strong></p>
	<ul>

	</ul>

</div>

      </div>
    </div>
  </body>

Screen Shot 2021-09-01 at 3 01 13 PM

  1. I review the parameters in the UI and do not see my change or any other changes.

Screen Shot 2021-09-01 at 3 01 29 PM

Additional Context:

  • there are no errors in the logs for the Admin app.
  • The contents of the pom.propertes: 
    #Generated by Maven
#Wed Apr 29 17:04:17 PDT 2020
groupId=ca.bc.gov.ols
artifactId=ols-router-admin
version=2.1.3-SNAPSHOT
@dkelsey dkelsey mentioned this issue Sep 1, 2021
Closed
@cmhodgson
Copy link
Collaborator

This bug is actually in the ols-util code, and I believe it was fixed for geocoder last year, perhaps by this commit:
bcgov/ols-util@c512342

We haven't tested/delivered a new version of router since then, so the new version of ols-util has not been included in the router yet. You could make this change in the POM but it will require testing as there are other changes to the ols-util that have not been tested in the router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkelsey @cmhodgson