-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to QR page #35
Conversation
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of the "What's being asked for" section, but John needs to drive that. I've offered a suggestion on the layout. The rest looks good.
I'll leave the code review to Wade.
Suggestion for cleanup of the "What's being asked for" -
Something like:
Would have to handle things like no restrictions, restrictions by schema, restrictions by cred def, restrictions by name, restrictions by value, etc. |
I need to put some thought into this, as I believe it ties in with the updates described in #34 (we don't currently support restrictions by value). We also need to be able to show @swcurran would it be okay to track those changes in a separate issue? |
Yup. That would be best. Just didn't want to leave it in Rocketchat.
…On Tue, Jan 21, 2020 at 3:55 PM Emiliano Suñé ***@***.***> wrote:
...
Would have to handle things like no restrictions, restrictions by schema,
restrictions by cred def, restrictions by name, restrictions by value, etc.
I need to put some thought into this, as I believe it ties in with the
updates described in #34
<#34> (we don't currently
support restrictions by value). We also need to be able to show
requested_predicates.
@swcurran <https://github.com/swcurran> would it be okay to track those
changes in a separate issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35?email_source=notifications&email_token=AAHYRQXP5HSWDTNONWFBA3TQ66DOTA5CNFSM4KJ36S4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRXCSI#issuecomment-576942409>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYRQTCSQ4UMWZGFDK5T3DQ66DOTANCNFSM4KJ36S4A>
.
--
Stephen Curran
Principal, Cloud Compass Computing, Inc. (C3I)
Technical Governance Board Member - Sovrin Foundation (sovrin.org)
*Schedule a Meeting: **https://calendly.com/swcurran
<https://calendly.com/swcurran>*
|
Initial redesign of QR code page