Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for angular units #30

Open
seth-pierson opened this issue Sep 30, 2023 · 0 comments
Open

[Feature Request] Add support for angular units #30

seth-pierson opened this issue Sep 30, 2023 · 0 comments

Comments

@seth-pierson
Copy link

Great Library!

Angular units are missing from the extensive list of units this library already supports. I plan to submit a PR adding support for that category of units.

I saw in #19 there was an example of how to add units, but that link is unfortunately broken. From my looking around my understanding is that I would call NewUnit() and that registers the new unit with the list of supported units. Likewise with NewRatioConversion() for conversions.

I will use volume_units.go and volume_units_test.go as templates for implementing the new units.

Is that a sound plan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant