Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol-Test: Remove unnecessary MAX_INV Limit to MAX_MESSAGE test / Or replace. #137

Open
jonajosejg opened this issue May 15, 2019 · 0 comments

Comments

@jonajosejg
Copy link
Contributor

The following Test found in
https://github.com/bcoin-org/bcash/blob/master/test/protocol-test.js#L151

The GetDataPacket size values to 1800003
Whilst the current updated MAX_MESSAGE value is 2097152

There is a possibility of changing the typeof invitems, or simply removing the test I'd be willing to hear out what is the better option. So that I can replace or remove the check in the test file for ci purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant