Installation for Windows not working or outdated.

[thehenrytsai]

Getting what seems like a python error, tried on both Python 2.x and 3.x, also installed windows-build-tools via various commands, including npm install -g --production windows-build-tools:

C:\WINDOWS\system32>npm install --global bcoin
C:\Users\hentsai\AppData\Roaming\npm\bwallet -> C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\bin\bwallet
C:\Users\hentsai\AppData\Roaming\npm\bcoin -> C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\bin\bcoin
C:\Users\hentsai\AppData\Roaming\npm\bcoin-spvnode -> C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\bin\spvnode
C:\Users\hentsai\AppData\Roaming\npm\bcoin-node -> C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\bin\node

[email protected] install C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\node_modules\mrmr
node-gyp rebuild || echo 'Build failed.'

C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\node_modules\mrmr>if not defined npm_config_node_gyp (node "C:\Users\hentsai\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild ) else (node "C:\Users\hentsai\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
File "", line 1
'from
^
SyntaxError: EOL while scanning string literal
gyp: Call to 'python -c 'from future import print_function; import sys; print(sys.byteorder)'' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (C:\Users\hentsai\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:345:16)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Windows_NT 10.0.17763
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\hentsai\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\hentsai\AppData\Roaming\npm\node_modules\bcoin\node_modules\mrmr
gyp ERR! node -v v10.14.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
'Build failed.'

[tynes]

bcoin should work on Windows, this seems like an issue with Python.

The error SyntaxError: EOL while scanning string literal seems to indicate that a string never terminates.

Could the problem be based on nesting a string in a string using ' for both strings? Maybe Windows is interpreting things differently than Linux/OSX.

[thehenrytsai]

Dug in a little further, looks like this happens when building dependency node_modules\mrmr and it throws on the following in its binding.gyp:

  "variables": {
    "mrmr_byteorder%":
      "<!(python -c 'from __future__ import print_function; import sys; print(sys.byteorder)')",
  },

[tuxcanfly]

Indeed, the issue is that the single quotes don't seem to be parsed as expected in Windows.

I have found that escaping the double quotes works in both Linux and Windows:

"<!(python -c \"from __future__ import print_function; import sys; print(sys.byteorder)\")"

I would like to find a better way or confirm if this is the best we can do before opening PRs (there are other dependencies which have the same issue).

[braydonf]

This is linked to #803

[braydonf]

Closed in #946