New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to nest context name instead of replace in log #10

Open

rithvikvibhu opened this issue Feb 9, 2023 · 0 comments

rithvikvibhu commented Feb 9, 2023

When passing loggers to other objects, it's sometimes useful to preserve the parent context name. For example, when running multiple nodes:

Currently:

With patch:

Patch used above (this is just an example, it can be made optional and custom separators, etc.):

diff --git a/old.js b/new.js
index 3d37a4c..bcbdc15 100644
--- a/old.js
+++ b/new.js
@@ -814,7 +814,7 @@ class LoggerContext {
    */
 
   context(module) {
-    return new LoggerContext(this.logger, module);
+    return new LoggerContext(this.logger, this.module + ':' + module);
   }
 
   /**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment