-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prospector not recognizing and fitting nebular lines #335
Comments
Hi Grace, I took a look at your repo. It looks like you're fitting photometry and not spectroscopy. Have you checked that you're able to get a good fit to the photometry that you're using as input? It may be that you're achieving a good fit but the underlying model spectra are very different. It looks like you're performing the filter integration in a for loop in your Best, |
Hi Joel, |
Hi Grace, Using sedpy you can do the filter projection in the same way Prospector does, e.g. from the sedpy documentation:
In some cases there can be substantive effects in filter projection methods that can affect the inferred magnitudes (e.g. the classic energy-counting vs photon-counting, treatment of interpolation, etc). Best to use the same approach as Prospector in this case. My shot-in-the-dark guess as to what's going on is that Prospector is matching the photometry to high precision but using a very different model spectrum than the input spectrum. This can either be for trivial reasons (e.g., unit bug, filter projection bug, etc, in which case sedpy might help get everything onto the same scale) or for very interesting science reasons (broadband filter degeneracies). Best, |
Thank you I'll implement this filter integration and see if that helps the fitting process. |
Hi Joel, I was wondering if there was a specific point in my build_obs function that is causing this.
|
Hi Grace, I'm not sure I can help very much unfortunately! This looks like a tough issue and my suspicion is that it's related to turning simulation data into physical SEDs, which is largely outside of the Prospector machinery. I'd check that the photometry you're synthesizing is consistent with the original spectrum, and I'd also check that putting the underlying parameters into a very simple Prospector SED model (i.e., matching mass, SFH, metallicity, hopefully no dust!) produces a spectrum which is (broadly) consistent with the output from the simulation. This can help sort out some of these issues. All Prospector can do here is try to generate a model spectrum which is in the best agreement with the input data as possible, and unless there's a suggestion that that's not happening (i.e. there is a solution that Prospector should find but isn't), there's not much we can do! Happy hunting... Best, |
While some of the underlying parameters are probably part of the larger issue, I'm more immediately concerned with the unit conversion issues right now where it seems to not really be matching anything.
|
Hi Grace, what are the units of |
Those are the units of the input spectrum already.On Jun 18, 2024, at 8:28 AM, Ben Johnson ***@***.***> wrote:
Hi Grace, what are the units of df['wav'] and df['spec']? The getSED function assumes units of observed frame AA and erg/s/cm^2/AA (i.e. f_lambda) respectively in order to produce AB magnitudes. I suggest doing the unit conversions on the input spectrum before calling getSED.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Ok, then you shouldn't need any of the obs["maggies"] = 10**(-phot/2.5)
obs["maggies_unc"] = 0.03 * 10**(-phot/2.5) |
Hi @gracekrahm any updates on this issue? |
I am trying to fit SEDs with nebular line emission and only a few of the lines are being with prospector. Even with the ones that are fit, the continuum is much higher than the fsps generated SED that we are fitting. This is especially evident at high redshifts.
.
All files used to generate the fsps mock SED and fit it using Prospector can be found here.
The text was updated successfully, but these errors were encountered: