Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom data? #150

Open
bdarcus opened this issue Jan 25, 2024 · 1 comment
Open

custom data? #150

bdarcus opened this issue Jan 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bdarcus
Copy link
Owner

bdarcus commented Jan 25, 2024

I've long thought there's a fundamental conflict between style portability (which is a non-negotiable requirement) and the freedom to use custom data.

But maybe I'm wrong, and there's some reasonable way?

Regardless, we need a mechanism to allow flexibility in the data model, whether it's through a formal extension mechanism, or a process that makes it easy to add new fields.

I will say the current code base already likely covers the latter; adding a new field would typically just be adding a value to some enum with a documentation string.

EDIT: the data model is now strongly-typed, so an invalid JSON or YAML import (e.g. with an unknown field) will panic.

OTOH, if some of the others ideas here (see #89) pan out, maybe we don't care about style portability as much?

@bdarcus bdarcus added the enhancement New feature or request label Jan 25, 2024
@denismaier
Copy link

IIRC, @cormacrelf had some ideas regarding this over on discourse. Need to look it up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants