Removed old/unused read_settings() interface

bdring · Oct 5, 2024 · a26bbe1 · a26bbe1
1 parent 10ce701
commit a26bbe1
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 16 deletions.
diff --git a/FluidNC/src/Motors/Dynamixel2.cpp b/FluidNC/src/Motors/Dynamixel2.cpp
@@ -106,8 +106,6 @@ namespace MotorDrivers {
         return true;
     }
 
-    void Dynamixel2::read_settings() {}
-
     // sets the PWM to zero. This allows most servos to be manually moved
     void IRAM_ATTR Dynamixel2::set_disable(bool disable) {
         if (_disabled == disable) {

diff --git a/FluidNC/src/Motors/Dynamixel2.h b/FluidNC/src/Motors/Dynamixel2.h
@@ -107,7 +107,6 @@ namespace MotorDrivers {
 
         // Overrides for inherited methods
         void        init() override;
-        void        read_settings() override;
         bool        set_homing_mode(bool isHoming) override;
         void        set_disable(bool disable) override;
         void        update() override;

diff --git a/FluidNC/src/Motors/MotorDriver.h b/FluidNC/src/Motors/MotorDriver.h
@@ -48,11 +48,6 @@ namespace MotorDrivers {
         // the stallguard debugging problem.
         virtual void debug_message();
 
-        // read_settings(), called from init(), re-establishes the motor
-        // setup from configurable arameters.
-        // TODO Architecture: Maybe this should be subsumed by init()
-        virtual void read_settings() {}
-
         // set_homing_mode() is called from motors_set_homing_mode(),
         // which in turn is called at the beginning of a homing cycle
         // with isHoming true, and at the end with isHoming false.

diff --git a/FluidNC/src/Motors/RcServo.h b/FluidNC/src/Motors/RcServo.h
@@ -41,9 +41,10 @@ namespace MotorDrivers {
             }
         }
 
+        void read_settings();
+
         // Overrides for inherited methods
         void init() override;
-        void read_settings() override;
         bool set_homing_mode(bool isHoming) override;
         void set_disable(bool disable) override;
         void update() override;

diff --git a/FluidNC/src/Motors/StandardStepper.cpp b/FluidNC/src/Motors/StandardStepper.cpp
@@ -19,11 +19,7 @@ using namespace Machine;
 namespace MotorDrivers {
 
     void StandardStepper::init() {
-        read_settings();
         config_message();
-    }
-
-    void StandardStepper::read_settings() {
         init_step_dir_pins();
     }
 
@@ -41,8 +37,6 @@ namespace MotorDrivers {
         if (_step_pin.canStep()) {
             Stepping::assignMotor(axisIndex, dualAxisIndex, _step_pin.index(), _step_pin.inverted(), _dir_pin.index(), _dir_pin.inverted());
         }
-
-        auto dir_gpio = _step_pin.getNative(Pin::Capabilities::Output);
     }
 
     void StandardStepper::config_message() {

diff --git a/FluidNC/src/Motors/StandardStepper.h b/FluidNC/src/Motors/StandardStepper.h
@@ -15,7 +15,6 @@ namespace MotorDrivers {
         // No special action, but return true to say homing is possible
         bool set_homing_mode(bool isHoming) override { return true; }
         void set_disable(bool) override;
-        void read_settings() override;
 
         void init_step_dir_pins();