Add an option to enable/disable SSDP and mDNS to save memory #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSDP can momentarily use a considerable amount (11k at least) of heap
|
I think the enum should be Enable and Disabled. The setting would be renamed to make that work. |
|
Ok, I think this is what you mean? |
|
We already have $Bluetooth/Enable, $Telnet/Enable, and $HTTP/Enable, with values On and Off. The naming should be similar. Perhaps $Sta/SSDP/Enable |
|
Merged....Thanks @vector76 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSDP can momentarily use a considerable amount (11k at least) of heap.
This change adds an option (enabled by default, so no change to default behavior) to allow disabling of SSDP and mDNS for those who want to save memory and go by IP address only.