Devt #1013
Merged
Devt #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uniform (and not redundant) treatment of "0x" with to_hex()
Raising priority of i2s task prevents main task time-slicing in
Breaks the cycle where reporting low memory can trigger more reporting
Fixes possible deadlock when pollLine grabs mutex and autoreport blocks
There were two problems. The first was that, after the reset, the arc calculation code was still trying to send more segments. The second was that the file input channel was closed, but the line processing code was trying to send an ack to it.
CRITICAL: Fix reset crash
SSDP can momentarily use a considerable amount (11k at least) of heap
Updating Spindle Uarts
If an arc is in progress when a feedhold followed by a ctrl-x reset comes in, the next move after the reset is wrong. For example: G0 X0 Y0 G3 X0 Y0 I-100 J0 F500 ! CTRL-X $J=G91 Z0.1 F100 Instead of the jog going only in the Z direction, there will be motion in X and Y too. The problem is caused by incorrect synchronization of the GCode position after the aborted arc. The code incorrectly sets the GCode position to the target of the arc, as if the arc had completed, instead of setting it to the actual position that existed at the time of the hold+reset. (It is possible that the same problem might occur without the feedhold, only the reset. In any case, this patch works in both scenarios.)
Fix crash when running numbered macros
Fix reset from arc
Add an option to enable/disable SSDP and mDNS to save memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$STA/SSDP/EnableThis allows you to disable SSDP and mDNS to save memory.