Fix repeat of 0, O commands with larger integer values #1335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs that this fixes -
o100 repeat [0]
would fail. I think this was due toskipping
being true by the time the parser got to the matchingendrepeat
, so it would effectively just end up skipping to the end of the file. The fix is to not check if we're skipping when we encounter anendrepeat
I think, because we already check if the top of the stack is its matchingrepeat
label.o300 if [1]
would fail because the int value of300
is cast to an int8_t, which is too small a type to contain 300. Upgradedint_value
toint32_t
to avoid this.repeat tested with the following