Stepping without using class vtables #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the need to move Motor and Pin vtables into RAM, thus saving about 20K of precious RAM space. It also simplifies the structure of the stepping code dramatically, so it is all in one place instead of being distributed throughout a complex class hierarchy.
Standard stepper and Trinamic Uart derivatives worked, but Trinamic SPI driver failed to call their base class's init() method.
The problem was that pulse_func() can do nothing if it is not awake, and in that case, the _pulse_data variable was holding old data.
* Fixed Generate_VCXProj * Moved VFD spindles to their own namespace and inheritance structure. TODO: Configuration. * Changed the factory a bit to ensure configurations still work. * This compiles. TODO: Loader script. * Changed names and made them consistent. This also removes them from IRAM. * Split out the VFDProtocol code into a separate file. * Added comment --------- Co-authored-by: Stefan de Bruijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the recent crash problems while saving DRAM space. It does so by coalescing the Stepping code that needs to be in IRAM into a single place (Stepping.cpp) instead of having bits of it distributed through the Axes / Motors / Pins hierarchies. This reduces the DRAM footprint by about 20K.
The only vtables that are still in DRAM are the .rodata sections from the Spindle classes.