Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling duplicate labels when converting from EDF to Onda #103

Open
kleinschmidt opened this issue Dec 19, 2024 · 0 comments
Open

handling duplicate labels when converting from EDF to Onda #103

kleinschmidt opened this issue Dec 19, 2024 · 0 comments

Comments

@kleinschmidt
Copy link
Member

Some EDF files we've encountered in the wild have duplicate labels/transducers. Currently, OndaEDF refuses to even plan such a file because duplicate channels are not allowed in Onda. I think we should probably relax that to a warning that becomes an error once you try to execute the plan, since the easiest way to fix this is by modifying the plan itself once it's generated; preprocessing the header requires changing the label which results in an error when executing since the label does not match the actual header.

We could also try to be clever and deduplicate things but that risks violating the assumption that only channel names explicitly listed in the label matchers will be included in the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant