Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore entries without amount in amount_map #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore entries without amount in amount_map #99

wants to merge 1 commit into from

Conversation

henrikssn
Copy link

Fixes #98

@dnicolodi
Copy link
Collaborator

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

@henrikssn
Copy link
Author

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

Yeah, I think you are right... Would a better solution be to store an (account, key): None entry in the map?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicator doesn't support entries with price and inferred amount
2 participants
@henrikssn @dnicolodi