Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test run #748

Merged
merged 21 commits into from
Sep 30, 2024
Merged

Improve test run #748

merged 21 commits into from
Sep 30, 2024

Conversation

mantzas
Copy link

@mantzas mantzas commented Sep 15, 2024

Which problem is this PR solving?

Resolves #747
Resolves #746

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (209dc78) to head (c7897ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/test/observability.go 53.84% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   84.89%   84.82%   -0.08%     
==========================================
  Files          64       65       +1     
  Lines        3111     3123      +12     
==========================================
+ Hits         2641     2649       +8     
- Misses        344      348       +4     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…mponent/http/component_test, component/amqp/component_test, component/sqs/component_test, correlation/correlation_test, client/sql/integration_test, component/http/router/router_test, client/http/encoding/json/json_test, component/http/middleware/logging_test, reliability/retry/retry_test, component/amqp/message_test, component/sqs/message_test, component/http/route_test, component/http/check_test, component/amqp/option_test, client/kafka/kafka_test, component/http/router/route_test, component/http/observability_test, cache/lru/lru_test
…fka, client/mongo, client/mqtt, client/sql, component/amqp, component/kafka, component/sqs, internal/test
…, component/grpc, client/amqp, client/kafka, client/sqs, client/grpc, internal/test, client/mqtt, client/sql, client/es, client/mongo, options_test, component/http/component_test, component/amqp/component_test, component/sqs/component_test, component/http/router/router_test, client/http/encoding/json/json_test, component/http/middleware/logging_test, reliability/retry/retry_test, component/amqp/message_test, component/sqs/message_test, component/http/route_test, component/http/check_test, component/amqp/option_test, client/kafka/kafka_test, component/http/router/route_test, component/http/observability_test, cache/lru/lru_test

Refactor mapHeader function in component/kafka/component.go

Update test assertions in component/amqp/integration_test.go, component/amqp/message_test.go, component/grpc/component_test.go, component/kafka/integration_test.go, component/sqs/component_test.go, component/sqs/integration_test.go, component/sqs/message_test.go, internal/test/assert.go, internal/test/assert_test.go

Remove unused assertSpan function in component/amqp/message_test.go, component/kafka/integration_test.go, component/sqs/message_test.go, internal/test/assert.go
…/elasticsearch_test.go, client/amqp/integration_test.go, client/grpc/grpc_test.go, client/kafka/integration_test.go, internal/test/observability.go, component/sqs/integration_test.go, client/mqtt/integration_test.go, component/amqp/integration_test.go, component/kafka/integration_test.go
…middleware.go

Remove unused code in examples/service/main.go
Remove testServer_SetupTracing function in integration_test.go
@mantzas mantzas marked this pull request as ready for review September 30, 2024 20:44
@mantzas mantzas merged commit 3ac48c6 into master Sep 30, 2024
3 of 4 checks passed
@mantzas mantzas deleted the test-improvements branch September 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test execution Extend test helper package
1 participant