Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on first run after iOS simulator is updated #780

Open
freakboy3742 opened this issue Jul 6, 2022 · 5 comments · May be fixed by #1828
Open

Error on first run after iOS simulator is updated #780

freakboy3742 opened this issue Jul 6, 2022 · 5 comments · May be fixed by #1828
Labels
bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start! iOS The issue relates to Apple iOS mobile support.

Comments

@freakboy3742
Copy link
Member

freakboy3742 commented Jul 6, 2022 •
edited by mhsmith
Loading

The first time you attempt to run an app in the iOS simulator after installing or updating the iOS simulator, the simulator fails to start at the point when it tries to identify the available simulators.

To Reproduce
Steps to reproduce the behavior:

  1. On a completely clean macOS install, install Xcode
  2. Generate a new Briefcase project
  3. run briefcase run iOS
  4. Briefcase fails with the error: "Unable to parse output of xcrun simctl":

briefcase.2022_07_06-11_12_50.run.log

The error will also occur when Xcode undergoes a major version update, and the simulator is updated.

Expected behavior

Briefcase should present a list of available simulator images on first run.

Environment:

  • Operating System: macOS (any)
  • Python version: any
  • Software versions:
    • Briefcase: 0.3.8

Additional context

The problem appears to be caused by stray content in the output being parsed. From the log above:

>>> Running Command:                                                                                                                                    subprocess.py:434
>>>     xcrun simctl list -j                                                                                                                            subprocess.py:435
>>> Command Output:                                                                                                                                     subprocess.py:453
>>>     Install Started                                                                                                                                 subprocess.py:455
>>>     1%.........20.........40.........60.........80.........Install Succeeded                                                                        subprocess.py:455
>>>     {                                                                                                                                               subprocess.py:455
>>>       "devicetypes" : [                                                                                                                             subprocess.py:455
>>>         {                                                                                                                                           subprocess.py:455
>>>           "productFamily" : "iPhone",                                                                                                               subprocess.py:455
>>>           "bundlePath" :                                                                                                                            subprocess.py:455
...

Briefcase currently takes the literal output of the command, and attempts to parse it as JSON. The stray content in the first two lines ("Install started, 1%... ") isn't valid JSON, so the parse fails.

When you run a second time, the stray content isn't present; the entire command output is parseable JSON.
@freakboy3742 freakboy3742 added bug A crash or error in behavior. up-for-grabs iOS The issue relates to Apple iOS mobile support. labels Jul 6, 2022
@freakboy3742
Copy link
Member Author

@rmartin16 Your logging work has paid off big time - this is the bug I've been trying to track for over a year, and I've finally been able to catch it!

@freakboy3742 freakboy3742 added the good first issue Is this your first time contributing? This could be a good place to start! label Jul 14, 2022
@mhsmith
Copy link
Member

mhsmith commented Dec 12, 2022

Confirmed that this is still an issue with the current version of Xcode.

@mhsmith
Copy link
Member

mhsmith commented Dec 12, 2022

@freakboy3742: I've renamed the tag "first-timers-only" to "good-first-issue" to avoid potentially losing contributions from second-time contributors.

Also, what's the purpose of "up-for-grabs"? It's currently on 67 out of 80 open issues, so it isn't conveying much information. It might be better to mark those issues which are not up for grabs by assigning them to someone.

@freakboy3742
Copy link
Member Author

@mhsmith No disagreement that "first-timers-only" isn't a great name, and that our tags could definitely do with some rationalisation. However, it's not just a matter of changing the name in the Github GUI; at the very least:

I've reverted this name change for now so we can have a more complete conversation about our desired end state for issue tagging across the project.

@mhsmith mhsmith mentioned this issue Dec 13, 2022
Closed
@ashleyplusplus
Copy link
Contributor

checking this out at pycon `24

@ashleyplusplus ashleyplusplus linked a pull request May 21, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A crash or error in behavior. good first issue Is this your first time contributing? This could be a good place to start! iOS The issue relates to Apple iOS mobile support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error on first run after iOS simulator update ashleyplusplus/briefcase
3 participants
@freakboy3742 @mhsmith @ashleyplusplus