Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with closing (z/Z) #1

Open
vonagam opened this issue Oct 28, 2018 · 0 comments · May be fixed by #2
Open

Problem with closing (z/Z) #1

vonagam opened this issue Oct 28, 2018 · 0 comments · May be fixed by #2

Comments

@vonagam
Copy link

vonagam commented Oct 28, 2018

Hi, thanks for library.

Found some problem in SVGData. I had simple path and when i loaded it with .Path everything worked fine, but when i manually called .Line and then .Close it didn't show.

Turns out that there are two bugs:

  1. Because z command does not have arguments, this check in LoadCommand prevents z command from loading and calling .Close. (numArgs will always be 0, as will argsIndex at the start)

  2. .Close method just makes line to .Start position. The problem is that .Start position never have been changed from Vector2.zero. That is why currently it makes opposite of closing shape - opening it if first point wasn't zero. (That's why my line which is actually is closed, loaded ok with .Path, but failed to show when i called .Close)

@vonagam vonagam linked a pull request Oct 29, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant