Remove thymeleaf, improve webflux support #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geirsagberg
requested review from
kagkarlsson,
sveinbma,
vegarrsm and
EskilTorland
geirsagberg
force-pushed
the
remove-thymeleaf
branch
3 times, most recently
from
bb70208 to
74ed594
Compare
When targeting es2022 we can use top level awaits to load config from a separate endpoint. This removes the dependency on thymeleaf for tepmlating, and we can serve the SPA fully static.
geirsagberg
force-pushed
the
remove-thymeleaf
branch
from
74ed594 to
5f5b7cb
Compare
By removing the dependency on spring-boot-starter-web, we make it easier to utilize in a webflux application. The added webflux example shows how to add a router function to serve the static assets.
geirsagberg
force-pushed
the
remove-thymeleaf
branch
from
8b33af4 to
1c764fd
Compare
Provides better IDE experience when editing settings.
geirsagberg
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the dependency on thymeleaf and allows serving the SPA fully static, for better compatibility with webflux projects.