Build directly to static and added heroku deployment #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveinbma
reviewed
Aug 29, 2023
| @@ -1,3 +1,3 @@ | |||
| server.port=8081 | |||
| server.port=${PORT:8081} | |||
| spring.datasource.url=jdbc:h2:file:./db-scheduler-ui-backend/test-db;MODE=PostgreSQL;DATABASE_TO_LOWER=TRUE;DEFAULT_NULL_ORDERING=HIGH | |||
There was a problem hiding this comment.
Funker den H2 greia her på heroku?
| @@ -0,0 +1,14 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Det blir egentlig litt rart å commite den "ferdigbygde" frontend appen inn i selve repoet vårt, den må jo bygges på nytt hver gang noe kommer inn på main
| @@ -5,7 +5,7 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "build": "tsc && vite build", | |||
| "build": "tsc && cross-env VITE_API_BASE_URL=https://jobjugglerapi-936dd3770db4.herokuapp.com/api vite build", | |||
There was a problem hiding this comment.
På sikt tror jeg vi må finne en annen måte å få "injecta" API-url'en inn i frontenden, for det skal jo bli generisk eller kunne konfigureres av de som bruker rammeverket
sveinbma
approved these changes
Aug 30, 2023
| @@ -5,7 +5,7 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "build": "tsc && vite build", | |||
| "build": "tsc && cross-env VITE_API_BASE_URL=https://jobjugglerapi-936dd3770db4.herokuapp.com/api vite build", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.