Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify generated html files by html_formatter #170

Open
pjrobertson opened this issue Jan 14, 2025 · 0 comments
Open

Minify generated html files by html_formatter #170

pjrobertson opened this issue Jan 14, 2025 · 0 comments
Labels
good first issue Good for newcomers nice to have Issues that are not a priority but would enrich the project.

Comments

@pjrobertson
Copy link
Collaborator

The html_formattery previously used the minify_html package to minify HTML and offer savings of about ~25% on the generated files (15KB vs. 20KB).

However, the minify_html package is incompatible with python3.13 (at the time of writing) and adds another dependency to the project. Alternative approaches for saving space should be considered. They include:

  1. Using some built-in method to minify and save space (if one exists)
  2. Minifying the template during build. I.e. create a template.min.html file during the build proccess, which is then stored in the repo and used by html_formatter.py by default
  3. Other ideas...

Note: minify_html was removed in this commit: 080f474

@msramalho msramalho added good first issue Good for newcomers nice to have Issues that are not a priority but would enrich the project. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers nice to have Issues that are not a priority but would enrich the project.
Projects
None yet
Development

No branches or pull requests

2 participants