Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Computer Show-Camera-List verb not listing ship security cameras. #7

Open
TerryTehCoder opened this issue Feb 6, 2021 · 3 comments

Comments

@TerryTehCoder
Copy link
Contributor

Round ID: N/A

Testmerges: N/A

Reproduction: The verb "show camera list" for the Ship Computer Job was not displaying a list of cameras properly. Only displaying deactivated cameras.

After further testing I concluded that this was not a issue with the code, but with the maps for the individual ships. The security cameras in question had not had their C_Tag configured meaning the tracking Dm file which organized the camera list was only identifying blanks and "deactivated" since the security cameras were not technically assigned a name for it to use.
https://github.com/ben11567/Star-Trek-13/blob/247a90fe906d36b2c230d381f37bf266d470a423/code/game/machinery/camera/tracking.dm
Lines 8-13, with special attention on line 13.

Solution: C_Tags must be configured in security cameras(Or computer sensor arrays if you prefer) throughout the ships. I plan to work on this but I don't currently know how to do pull requests and all that for github, however feel free to let me know if you're working on this.

C_Tag when assigned in Sovereign Brig Security Camera:
Ctag assigned

Tracking.Dm functioning and displaying the C_Tag in the camera list, along with no others as this is the only tag i've assigned for testing purposes:
CTagfunctioning

This is my first time using github for issue reports so please let me know if these needs to be moved.

@TerryTehCoder
Copy link
Contributor Author

Status Update: I have figured out how pull requests work. Glorious day it is. Now on with adding C_tags to multiple ships with multiple decks of cameras...

@TerryTehCoder
Copy link
Contributor Author

Progress has been good. Sovereign security cameras have been assigned c_tags and merged and I'm currently moving onto the Intrepid Class Light Cruiser today.

@TerryTehCoder
Copy link
Contributor Author

Intrepid security cameras have been updated in #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant