-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance sort uses the wrong json structure. #150
Comments
berkes
added a commit
to berkes/rs-es
that referenced
this issue
Jun 6, 2020
This fixes issue benashford#150, where the JSON is wrong for distance sorting. The structure is a little non-standard, as it is wrapped in an object with hardcoded _geo_distance as name. Reaching through inner-outer and tupled structs is unfortunate, but seems to be nessecary in order to keep the API the same and to keep everything nicely contained inside a GeoDistance struct as seen from the consumer or user.
berkes
added a commit
to berkes/rs-es
that referenced
this issue
Jun 6, 2020
This fixes issue benashford#150, where the JSON is wrong for distance sorting. The structure is a little non-standard, as it is wrapped in an object with hardcoded _geo_distance as name. Reaching through inner-outer and tupled structs is unfortunate, but seems to be nessecary in order to keep the API the same and to keep everything nicely contained inside a GeoDistance struct as seen from the consumer or user.
berkes
added a commit
to berkes/rs-es
that referenced
this issue
Jun 6, 2020
This fixes issue benashford#150, where the JSON is wrong for distance sorting. The structure is a little non-standard, as it is wrapped in an object with hardcoded _geo_distance as name. Reaching through inner-outer and tupled structs is unfortunate, but seems to be nessecary in order to keep the API the same and to keep everything nicely contained inside a GeoDistance struct as seen from the consumer or user.
berkes
added a commit
to berkes/rs-es
that referenced
this issue
Jun 6, 2020
This fixes issue benashford#150, where the JSON is wrong for distance sorting. The structure is a little non-standard, as it is wrapped in an object with hardcoded _geo_distance as name. Reaching through inner-outer and tupled structs is unfortunate, but seems to be nessecary in order to keep the API the same and to keep everything nicely contained inside a GeoDistance struct as seen from the consumer or user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When crafting a distance sort, we get a wrong JSON structure:
This gives us a:
But it should be:
The text was updated successfully, but these errors were encountered: