Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't rely on internal scikit-learn functions #16

Open
jolars opened this issue Jun 20, 2022 · 1 comment
Open

refactor: don't rely on internal scikit-learn functions #16

jolars opened this issue Jun 20, 2022 · 1 comment

Comments

@jolars
Copy link
Collaborator

jolars commented Jun 20, 2022

We are current using _preprocess_data from sklearn.linear_model, but it is not a public API and should not be used. This just created a problem for me since they dropped the return_mean argument, which caused the benchmark to fail.
@mathurinm
Copy link
Collaborator

It's a concern for me too in celer. I have not found a satisfying solution yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathurinm @jolars