Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong import: torch_geometric.utils.to_dense_adj #267

Open
ber0i opened this issue Mar 17, 2024 · 8 comments
Open

Wrong import: torch_geometric.utils.to_dense_adj #267

ber0i opened this issue Mar 17, 2024 · 8 comments

Comments

@ber0i
Copy link

ber0i commented Mar 17, 2024

Hi,
There is a broken import in torch_geometric_temporal\nn\attention\tsagcn.py, line 6:
from torch_geometric.utils.to_dense_adj import to_dense_adj
should be changed to
from torch_geometric.utils._to_dense_adj import to_dense_adj.
Would be great if that could be fixed. Thanks!

@anna-inf-met
Copy link

Really hoping the above can be fixed, in order to be able to use torch geometric temporal

@Ziqi-Li
Copy link

Ziqi-Li commented Apr 5, 2024

@anna-inf-met You can just change your local tsagcn.py as suggested by @ber0i .

@louiswng
Copy link

louiswng commented May 2, 2024

@anna-inf-met You can just change your local tsagcn.py as suggested by @ber0i .

In what directory should I put the tsagcn.py file?
What is the directory structure?
Could you please provide more information?

@ber0i
Copy link
Author

ber0i commented May 2, 2024

@louiswng When installing a package, say torch_geometric_temporal, the corresponding code is stored somewhere on your computer. For example, I use miniconda and all torch_geometric_temporal code installed to a virtual environment can be found in

C:\Users[user name]\AppData\Local\miniconda3\envs[env name]\Lib\site-packages\torch_geometric_temporal

You can then navigate to torch_geometric_temporal\nn\attention\tsagcn.py and open and edit the code as described above.

Does that help? Let me know if there's still an open question. :)

@louiswng
Copy link

louiswng commented May 2, 2024

@louiswng When installing a package, say torch_geometric_temporal, the corresponding code is stored somewhere on your computer. For example, I use miniconda and all torch_geometric_temporal code installed to a virtual environment can be found in

C:\Users[user name]\AppData\Local\miniconda3\envs[env name]\Lib\site-packages\torch_geometric_temporal

You can then navigate to torch_geometric_temporal\nn\attention\tsagcn.py and open and edit the code as described above.

Does that help? Let me know if there's still an open question. :)

Problem solved, thank you very much.

@christoschr97
Copy link

Hey people! Any update on this bug?

@ber0i
Copy link
Author

ber0i commented Jul 9, 2024

Hey people! Any update on this bug?

Unfortunately not, I've recently installed the package in another environment and had to do the manual fix again. It just takes a second though :)

@obrooks-quest
Copy link

PR: #269

Can this be looked at by someone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants