Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nested ordered and unordered lists #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ericvb
Copy link

@ericvb ericvb commented Jan 20, 2014

I think that this is a usefull extension to the existing code.
Just a remark: I didn't have time to extend the test methods, should yet be done.

- upgrade to Migradoc version 1.32.4334.0
- adding global assembly principe
- adding support for nested unorderen and ordered lists (take in account
the limit to 3 levels per type of list! So maximum 6 levels deep if you
mix the lists)
@BenLewies
Copy link

@ericvb This worked for me, thanks. Have you tested this on headers nested within lists as well?

@jozcar
Copy link

jozcar commented Apr 13, 2016

Hi there, will this update be merge into the main branch?

@ericvb
Copy link
Author

ericvb commented Apr 14, 2016

It's already 2 years ago that I did this pull request.
It is up to benfoster to merge this, I have no write access, but seeing that this pull request is 2 years old, I doubt that this project is still active and that it will be done...
Another option is to branch yourself and to merge all branches in your new 'main' branch.

@ericvb
Copy link
Author

ericvb commented Apr 14, 2016

@BenLewies I see an already old comment from you, sorry I did miss it at that time I think.
I did this correction/extension for a specific need in my project, so no, I didn't test it with nested headers.
The project developped at that time is still running, but there are no plans to extend it, so I will not receive dev-time to test this out, sorry.

@benfoster
Copy link
Owner

I'll look at this again today/tomorrow.

On Thursday, 14 April 2016, ericvb [email protected] wrote:

@BenLewies https://github.com/BenLewies I see an already old comment
from you, sorry I did miss it at that time I think.
I did this correction/extension for a specific need in my project, so no,
I didn't test it with nested headers.
The project developped at that time is still running, but there are no
plans to extend it, so I will not receive dev-time to test this out, sorry.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants