Fix shell completions (#522)

We had a panic happen on running `py-spy completions bash`, due
to clap-rs/clap#3826 .

Fixes #520

Author: benfred

Cargo.toml

@@ -13,8 +13,8 @@ edition="2021"
 
 [dependencies]
 anyhow = "1"
-clap = {version="3.1", features=["wrap_help", "cargo", "derive"]}
-clap_complete="3.1"
+clap = {version="3.2", features=["wrap_help", "cargo", "derive"]}
+clap_complete="3.2"
 console = "0.15"
 ctrlc = "3"
 indicatif = "0.16"

src/config.rs

@@ -323,9 +323,9 @@ impl Config {
                 config.dump_locals = matches.occurrences_of("locals");
             },
             "completions" => {
-                let shell = matches.value_of_t::<clap_complete::Shell>("shell")?;
+                let shell = matches.get_one::<clap_complete::Shell>("shell").unwrap();
                 let app_name = app.get_name().to_string();
-                clap_complete::generate(shell, &mut app, app_name, &mut std::io::stdout());
+                clap_complete::generate(*shell, &mut app, app_name, &mut std::io::stdout());
                 std::process::exit(0);
             }
             _ => {}

tests/integration_test.py

@@ -99,10 +99,18 @@ def test_thread_names(self):
             if expected_thread_names == actual_thread_names:
                 break
         if expected_thread_names != actual_thread_names:
-            print("failed to get thread names", expected_thread_names, actual_thread_names)
+            print(
+                "failed to get thread names",
+                expected_thread_names,
+                actual_thread_names,
+            )
 
         assert expected_thread_names == actual_thread_names
 
+    def test_shell_completions(self):
+        cmdline = [PYSPY, "completions", "bash"]
+        subprocess.check_output(cmdline)
+
 
 def _get_script(name):
     base_dir = os.path.dirname(__file__)