Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph or Flamecharts ? #749

Open
BerengerBerthoul opened this issue Feb 28, 2025 · 0 comments
Open

Flamegraph or Flamecharts ? #749

BerengerBerthoul opened this issue Feb 28, 2025 · 0 comments

Comments

@BerengerBerthoul
Copy link

Thanks for the library, it is very useful!

While the documentation says that py-spy produces Flamegraphs, I think it actually produces Flamecharts

From https://www.brendangregg.com/flamegraphs.html:

While inspired by flame graphs, flame charts put the passage of time on the x-axis instead of the alphabet. This means that time-based patterns can studied. Flame graphs reorder the x-axis samples alphabetically, which maximizes frame merging, and better shows the big picture of the profile.

Now I'm actually glad flamecharts are produced, but unless I am mistaken, maybe the documentation should be updated? And maybe explicitely tell users that the other alternative is currently not implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant