Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play-json #2

Open
antonkulaga opened this issue Sep 27, 2014 · 3 comments
Open

play-json #2

antonkulaga opened this issue Sep 27, 2014 · 3 comments

Comments

@antonkulaga
Copy link
Contributor

It would be nice to see play-json pickler (maybe as separate subproject) like it is in scala-js-picklers

@benhutchison
Copy link
Owner

That shouldn't be very difficult. I'll try to add this at some point.

On Sun, Sep 28, 2014 at 7:29 AM, Anton Kulaga [email protected]
wrote:

It would be nice to see play-json pickler (maybe as separate subproject)
like it is in scala-js-picklers


Reply to this email directly or view it on GitHub
#2.

@antonkulaga
Copy link
Contributor Author

I started coding play-json support but had to pause due to more importants todos. But what I undestood from my attempt is that generic test suites are missing, so everyone can make a subproject for his/her own favourite json lib and extend some generic test suite to test if everything is ok with readers/writers.

@benhutchison
Copy link
Owner

IIRC supporting another json framework should involve just a new PBuilder
and PReader:

https://github.com/benhutchison/prickle/blob/master/shared/src/main/scala/prickle/PConfig.scala#L38

Currently the tests dont really focus on this in isolation, partly because
its lower risk relative to the main un/pickling logic. Some explicit
contract testing along these interfaces would be valuable and not
especially difficult, and could be made generic.

On Mon, Feb 16, 2015 at 11:33 AM, Anton Kulaga [email protected]
wrote:

I started coding play-json support but had to pause due to more importants
todos. But what I undestood from my attempt is that generic test suites are
missing, so everyone can make a subproject for his/her own favourite json
lib and extend some generic test suite to test if everything is ok with
readers/writers.


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants