Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fody weaver should detect weaver/library version mismatches #27

Open
benjamin-bader opened this issue Aug 14, 2013 · 1 comment
Open
Labels

Comments

@benjamin-bader
Copy link
Owner

Currently, it fails with an unhelpful key-not-found stacktrace from StilettoReferences.cs. Nicht sehr gut.

@benjamin-bader
Copy link
Owner Author

More details on the nature of this problem:

StilettoReferences assumes that certain classes and methods are present in Stiletto.dll, and obtains references to them by name-matching, with strings. This is necessary to allow the same weaver to work on multiple platforms; otherwise, references to the .NET 4.0 version would be embedded in, say, a Windows Phone build where that library obviously would be neither available nor functional.

This issue happens when Stiletto is refactored, such as the rename from IPlugin to ILoader, without updating StilettoReferences; in this situation, obviously the missing types are not found. The problem is that the weaver does not gracefully handle itself, and the error presented offers no indication.

The solution has multiple components. For one, we need to start embedding version numbers in the Stiletto assemblies themselves; this ought to happen automatically. For another, the weaver needs to know the latest version it can handle, and needs to use that information to craft a useful error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant