Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More customisation options #6

Open
oililly opened this issue Jul 31, 2021 · 1 comment
Open

More customisation options #6

oililly opened this issue Jul 31, 2021 · 1 comment

Comments

@oililly
Copy link

oililly commented Jul 31, 2021

Option to toggle between simplified or traditional characters and info on key press.
Option to change the default colour of the background of the simplified or traditional hanzi sections of the pop-up (at the moment it's impossible to tell at a glance where the simplified word ends and the traditional begins, especially in longer words where the first characters are different in simplified and traditional).
Option to hide logo and buttons (or to move them to the bottom) so character info can begin at the top of the screen.
Option to choose the order in which character info is displayed (e.g. radical info first, then definition, then words, etc).
Option to reposition pop-up or to choose pop-up location (multiple extensions with pop-ups often interfere with each other).

Other:
Different customisable color schemes (light, sepia, dark).
Show pop-up on hover with customisable delay.

Bug:
Control hot key maps onto right Alt.

@benlieb
Copy link
Owner

benlieb commented Sep 15, 2022

  • Option to toggle between simplified or traditional characters and info on key press.

    • I'm not sure what you mean here. Could you elborate? Do you mean only showing simplified OR traditional? And have it toggleable with a key press?
  • Option to change the default colour of the background of the simplified or traditional hanzi sections of the pop-up (at the moment it's impossible to tell at a glance where the simplified word ends and the traditional begins, especially in longer words where the first characters are different in simplified and traditional).

    • I'm going to implement a fix for this immediately, by added a vertical divider, and by making larger words smaller font.
  • Option to hide logo and buttons (or to move them to the bottom) so character info can begin at the top of the screen.

  • Option to choose the order in which character info is displayed (e.g. radical info first, then definition, then words, etc).

  • Option to reposition pop-up or to choose pop-up location (multiple extensions with pop-ups often interfere with each other).

    • This is interesting and tricky. The popup location is not fixed but sometimes above, sometimes below, sometimes right sometimes less right. It follows a complex set of calculations for where it is positioned, and wouldn't be easily customizeable. Screenshot below. What could be configurable is the "offset" I've bumped this up to 150 and 200 and verifed that it works ok. I may choose to implement this at some point.

Other:

  • Different customisable color schemes (light, sepia, dark).
    • I like this idea.
  • Show pop-up on hover with customisable delay.
    • Do you mean as an "alternative" to using the modal hot key?

Bug:

  • Control hot key maps onto right Alt.
    • On my keyboard it maps to either. What are you using?

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants