Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken feed #46

Open
nathanspeller opened this issue Jun 23, 2016 · 9 comments
Open

Broken feed #46

nathanspeller opened this issue Jun 23, 2016 · 9 comments

Comments

@nathanspeller
Copy link

Multiple apps, including my HN Reader app have been broken for a few days now. Not sure if the recent commit broke the scraper?

@jchomali
Copy link
Collaborator

Completely sure it didnt. You can check out any of this apps that displays the posts correctly and uses libHN for doing so.

El jun 22, 2016, a las 21:34, nathanspeller [email protected] escribió:

Multiple apps, including my HN Reader app have been broken for a few days now. Not sure if the recent commit broke the scraper?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@hamin
Copy link
Contributor

hamin commented Jun 23, 2016

@nathanspeller @jchomali i can confirm that my app is broken too http://mackernews.com . I reinstalled my app which should fetch the latest configuration file. Something most definitely is up IMHO

@nathanspeller
Copy link
Author

@jchomali hnreader.com is my app. I've confirmed with a few users that the feed isn't loading for them. I've tried redownloading the app which I imagine would force a fetch of the latest config file, but no luck. Also doesn't work locally in Xcode.

The following hn reader is also experiencing the same problems:
hn. - Yet Another Hacker News Client by Faiz Mokhtar
https://appsto.re/us/4KTO_.i

@jchomali
Copy link
Collaborator

Redownloading the app will not fix the problem if the configuration file was imported wrong.
Can you please try my app, Boreal, and tell me if you see any posts? If you dont see any posts please kill the app twice and look again. If Boreal doesnt throws the error then the problem can not be the configuration file.

El jun 23, 2016, a las 01:27, nathanspeller [email protected] escribió:

@jchomali hnreader.com is my app. I've confirmed with a few users that the feed isn't loading for them. I've tried redownloading the app which I imagine would force a fetch of the latest config file, but no luck. Also doesn't work locally in Xcode.

The following hn reader is also experiencing the same problems:
hn. - Yet Another Hacker News Client by Faiz Mokhtar
https://appsto.re/us/4KTO_.i


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jchomali
Copy link
Collaborator

@nathanspeller I can confirm that your app shows the posts after reinstalling the app and the killinkg it one time. After that it shows me the posts. Please try doing some logging to the see if the configuration file is being downloaded and replaces the old file.

@nathanspeller
Copy link
Author

@jchomali I tried your Boreal app. It also did not show any posts until I killed it first. Re-downloading and killing my own app also got my app to show posts. Post are also now showing in my local version.

This is still a bad situation since all of these apps won't show posts until they're killed. My other users still have no posts even after killing and reopening the app. I believe I'm loading the configuration file correctly but I'm not sure how to test this now that my local versions are retrieving the correct configuration file.

I agree that the latest configuration file is working, but something else seems to be broken.

@hamin is your app still having issues?

@nathanspeller
Copy link
Author

@jchomali did you do anything in Boreal besides including calling HNManager.sharedManager().startSession() inside didFinishLaunchingWithOptions?

This seems like the only time that a new configuration file would be loaded. However, when logging in the simulator, I find that didFinishLaunchingWithOptions is NOT called when exiting and reopening the app. It is also NOT called when you kill the app and reopen it!! This is news to me.

When will a casual user actually call didFinishLaunchingWithOptions? When their phone restarts?

@hamin
Copy link
Contributor

hamin commented Jul 3, 2016

Not sure what's going on but my feed is still messed up on my app http://mackernews.com . I actually updated the Podfile to point to the latest commit on master and still it seems to be broken. Right now trying to build a new version to upload to Mac App Store. Will keep everyone posted

@hamin
Copy link
Contributor

hamin commented Dec 16, 2016

just an update @bennyguitar's last commit fixed it for my app without any update whatsoever :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants