Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation #319

Open
1 of 4 tasks
peebeebee opened this issue Feb 2, 2025 · 0 comments
Open
1 of 4 tasks

Optimisation #319

peebeebee opened this issue Feb 2, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@peebeebee
Copy link

Issue Type

  • Reporting a typo
  • Reporting a documentation bug
  • Documentation improvement
  • Documentation feedback

Request Description

In the electron.config.ts file, it states

if (options.optimization) {
    webpackConfig.optimization = {
      minimize: false,
      concatenateModules: false,
    };
  }

The tests also confirm this should be correct

 describe('the optimization option when true', () => {
    it('should not minify', () => {

I do wonder why? Shouldn't optimisation actually minify?

I'd love to have this clarified a bit. I am willing to open a pull request for this.

@peebeebee peebeebee added the documentation Improvements or additions to documentation label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant