Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected message when using async once #479

Closed
critch opened this issue Feb 24, 2018 · 6 comments
Closed

Unexpected message when using async once #479

critch opened this issue Feb 24, 2018 · 6 comments

Comments

@critch
Copy link

critch commented Feb 24, 2018

I wrote a very simple test case in elixir. From best I can tell, my example is nothing more than your documented async example, just with stream_next called to handle the once argument, and a timer.sleep of about 1000 to simulate a work load being made on the results.

Best I can guess, there must be a race condition that is easier to cause when there is a sufficiently large delay between the stream_next calls. I'm guessing the socket has sent all the data, and closed before our last call to stream_next.

This was tested with the 1.11 release.

@critch
Copy link
Author

critch commented Feb 25, 2018

This may be related to #464

@critch critch mentioned this issue Feb 27, 2018
@benoitc
Copy link
Owner

benoitc commented Feb 27, 2018

can you try #482 ?

@critch
Copy link
Author

critch commented Feb 28, 2018

As a bit of help, I modified the 3 instances of the unexpected message logs and found this one is on line 151.

@rozap
Copy link
Contributor

rozap commented Mar 6, 2018

I'm observing the same thing. I've tried #482 but it doesn't seem to do the trick. I'll continue looking at what's going on.

@benoitc
Copy link
Owner

benoitc commented Apr 3, 2018

should be fixed in latest master.

@benoitc benoitc closed this as completed Apr 3, 2018
@critch
Copy link
Author

critch commented Apr 14, 2018

finally able to test. So far it does appear to be fixed. Tried with a 10mb file using a 1 second delay in between messages. No issues.

Thank you for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants