Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache not removing expired items #4

Open
zoli opened this issue Mar 17, 2024 · 1 comment
Open

Cache not removing expired items #4

zoli opened this issue Mar 17, 2024 · 1 comment

Comments

@zoli
Copy link
Contributor

zoli commented Mar 17, 2024 •
edited
Loading

Shouldn't the janitor call DeleteExpired method? Currently expired items are always available. They never get cleaned, janitor only calls onExpired callback. I think it should also call DeleteExpired.
@markpash
Copy link
Member

Shouldn't the janitor call DeleteExpired method? Currently expired items are always available. They never get cleaned, janitor only calls onExpired callback. I think it should also call DeleteExpired.

Hey, thanks for the bug report. I haven't worked on this codebase before and I'm mostly responsible for it now, so please give me time before I can get to this. But if you feel like you're confident that there's a bug, feel free to send a PR with a fix and I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zoli @markpash