Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/n] feat(state): Process deposits with proof verification and beacon state deposit root #2287

Open
wants to merge 25 commits into
base: deposit-datatype
Choose a base branch
from

Conversation

calbera
Copy link
Contributor

@calbera calbera commented Dec 17, 2024

NOT backwards compatible with boonet

@calbera calbera changed the base branch from main to 4881-spec-tests December 17, 2024 17:40
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 36.32479% with 149 lines in your changes missing coverage. Please review.

Project coverage is 31.55%. Comparing base (566d431) to head (e607ee2).

Files with missing lines Patch % Lines
state-transition/core/state_processor_staking.go 52.17% 13 Missing and 9 partials ⚠️
execution/deposit/contract.go 0.00% 21 Missing ⚠️
storage/deposit/store.go 63.46% 16 Missing and 3 partials ⚠️
state-transition/core/state_processor_genesis.go 40.74% 5 Missing and 11 partials ⚠️
consensus/cometbft/service/genesis.go 0.00% 10 Missing ⚠️
beacon/validator/block_builder.go 0.00% 9 Missing ⚠️
storage/beacondb/eth1.go 0.00% 9 Missing ⚠️
storage/deposit/merkle/tree.go 47.05% 9 Missing ⚠️
beacon/blockchain/pruning.go 0.00% 8 Missing ⚠️
beacon/blockchain/deposit.go 0.00% 7 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           deposit-datatype    #2287      +/-   ##
====================================================
- Coverage             31.73%   31.55%   -0.19%     
====================================================
  Files                   338      337       -1     
  Lines                 15709    15533     -176     
  Branches                 20       20              
====================================================
- Hits                   4985     4901      -84     
+ Misses                10375    10288      -87     
+ Partials                349      344       -5     
Files with missing lines Coverage Δ
beacon/blockchain/execution_engine.go 0.00% <ø> (ø)
beacon/blockchain/payload.go 0.00% <ø> (ø)
beacon/blockchain/process_proposal.go 0.00% <ø> (ø)
consensus-types/types/body.go 76.28% <ø> (ø)
node-core/components/chain_service.go 0.00% <ø> (ø)
node-core/components/service_registry.go 0.00% <ø> (ø)
primitives/merkle/proof.go 86.04% <100.00%> (-0.63%) ⬇️
state-transition/core/state_processor.go 41.94% <ø> (+2.57%) ⬆️
storage/deposit/merkle/helpers.go 79.16% <100.00%> (-0.57%) ⬇️
storage/deposit/merkle/node.go 49.65% <100.00%> (ø)
... and 18 more

@calbera calbera changed the title [WIP 3/n] feat(state): Process deposits with proof verification and beacon state deposit root [WIP 4/n] feat(state): Process deposits with proof verification and beacon state deposit root Dec 17, 2024
@calbera calbera changed the base branch from 4881-spec-tests to deposit-datatype December 18, 2024 00:38
@calbera calbera requested a review from sbudella-gco December 18, 2024 03:12
@calbera calbera marked this pull request as ready for review December 18, 2024 05:23
@calbera calbera changed the title [WIP 4/n] feat(state): Process deposits with proof verification and beacon state deposit root [4/n] feat(state): Process deposits with proof verification and beacon state deposit root Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant