Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incentive token ERC20s must not consume more than 500k gas #326

Open
calbera opened this issue Nov 4, 2024 · 0 comments
Open

Incentive token ERC20s must not consume more than 500k gas #326

calbera opened this issue Nov 4, 2024 · 0 comments

Comments

@calbera
Copy link

calbera commented Nov 4, 2024

What is the type of issue?

Documentation is missing

What is the issue?

dapps’ incentive ERC20 tokens cannot have transfer funcs that consume more than 500k gas (otherwise their incentive token will never transfer to validators and delegates)

Will need to manually audited and reviewed before whitelisting any erc20 token as incentive.

From auditors: It's technically possible, albeit highly unlikely, for a legitimate token transfer to cost more than 500k gas, particularly for tokens with non-standard mechanisms such as rebasing, fee-on-transfer, liquidity management, etc..

Where did you find it?

https://github.com/berachain/contracts-monorepo/pull/468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant