Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caller of FeeCollector.claimFees() has to implement slippage check #327

Open
bar-bera opened this issue Nov 5, 2024 · 0 comments
Open

Caller of FeeCollector.claimFees() has to implement slippage check #327

bar-bera opened this issue Nov 5, 2024 · 0 comments

Comments

@bar-bera
Copy link

bar-bera commented Nov 5, 2024 •
edited
Loading

What is the type of issue?

Documentation is missing

What is the issue?

As addressed in spearbit #H-14, FeeCollector.claimFees() is susceptible to front-run transaction. Would be helpful to add some snippet of code to the docs for callers, showing how to implement the check on output tokens to avoid being front-run.

Also added a line of natspec in contracts-monorepo #473

Where did you find it?

spearbit #H-14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bar-bera