Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues with PreSpawnerSpawnEvent #133

Open
JPlayer3 opened this issue Oct 11, 2021 · 1 comment
Open

Performance issues with PreSpawnerSpawnEvent #133

JPlayer3 opened this issue Oct 11, 2021 · 1 comment

Comments

@JPlayer3
Copy link

BkCommonLib version: v1.17.1-v5-SNAPSHOT
Paper version: paper-287

Problem or bug:

698fd9f60dd679dbac2ecb1102da11f9

After starting the server, I left it as it was and measured it.

@bergerkiller
Copy link
Member

Given it fired 2.2 million times in that period, it seems kind of low? I think you're mostly measuring the overhead of timings itself, since every call a tiny bit of time is lost executing nanoTime(), which during normal operation doesn't happen.

That said though, it's possible to detect whether anyone is actually using that event (normally only when MyWorlds is installed) and turn off the event entirely if nobody is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants