Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure example works out of the box #2

Open
rylandg opened this issue Jun 27, 2018 · 1 comment
Open

Make sure example works out of the box #2

rylandg opened this issue Jun 27, 2018 · 1 comment

Comments

@rylandg
Copy link

rylandg commented Jun 27, 2018

Currently there is some documentation mismatching with the example.

With this step for instance

cat example/{clientDeps,serverDeps} | sort -u | xargs npm i

it should actually be

cat generated/{clientDeps,serverDeps} | sort -u | xargs npm i

I would also recommend adding some command to generate a very simple template setup (maybe the client.ts and server.ts used in the README.

@bergundy
Copy link
Owner

Thanks, fixed the issue in README.md.
I'd have to think about generating template setup, it's a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants