Use New API URL

[ejunker]

OneSignal has a new base API URL

According to their API documentation:

Make sure your API requests are using https://api.onesignal.com and not the legacy https://onesignal.com/api/v1/ URL.

It looks like this would need to be updated in OneSignalClient.php

[mass5]

Yes, correct https://documentation.onesignal.com/docs/keys-and-ids?_gl=1*95kqw8*_gcl_au*MTg4MjQyNDc0OC4xNzMzNzc1NTcxLjIzMDc0NTY3NS4xNzMzOTU0OTY5LjE3MzM5NTUwMTI.*_ga*NjU5NTIwNzk2LjE3MzM3NzU1Njk.*_ga_Z6LSTXWLPN*MTczMzk1NDQ5Ny4zLjEuMTczMzk1NzcxMC41MC4wLjY3NzM3MzA4OQ..#migrating-from-legacy-api-keys

[mass5]

my #197 PR should fix this

[lcon91]

I think this feature should be resolved with an optional variable, avoiding problems with using ^2.x composer.
This change broke my homolog environment. Fortunately, it did not got to production.
If people using this lib have to change it's own environment, it is not a minor change.

[mass5]

Thanks for the feedback @lcon91 I'm glad you found a way to fix your issue.
Are you aware that on the 1st of March 2025 all the legacy user API keys will be deprecated? What this means is that if you don't update your keys with the new URL, it will stop working. From what I understand, you have 1 month left. Is this correct? Can you confirm?

[lcon91]

Actualy I wasn't, but there's a way to work with this solution without having to force a new variable in environment.
The const that had been removed might be changed with the new URL and then could've been used an optional parameter in the constructor or, even better, inside the constructor it could've been used a variable that use the env variable OR use the const when the env var didn't exist.

For this solution, the new lib version had to be 3.0, since it require a new environment variable (breaking change)

[mass5]

Thanks for the review @lcon91
I tried to make this as flexible as possible so if people are still using the old URL they can use the new code but set up their old URL in the .env settings to override the value.
One more thing, even if you are missing the .env value, the code has a default URL set in the config file /config/onesignal.php

'rest_api_url' => env('ONESIGNAL_REST_API_URL', 'https://api.onesignal.com'),

Does this answer your question?

[lcon91]

Actually, it has now, in the 2.3 version. Before this, it didn't have any workaround. That's why it is a breaking change.
I don't have any question. Just a feedback.

[throcha3]

Fixed in the 2.4 release, guys! Thanks everyone