You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
System.out.printf("Could not load animation: %s. Is it missing?", rawAnimation.animationName);
encounteredError.set(true);
}
System.out.printfwill not emit a newline after printing, so you can end up with scenarios where you see something like the following in your logs:
Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?Could not load animation: death. Is it missing?[18:20:19] [Render thread/WARN] [minecraft/ClientPacketListener]: Received passengers for unknown entity
Instead, a Logger should be use so that
it identifies the source of the log message
it properly indicates that it is a warning/error
it prints a newline at the end of the message, avoiding these very long lines
If, for whatever reason, it is not possible to use a logger, then consider at the very least doing one of the following:
System.out.printf("Could not load animation: %s. Is it missing?%n", rawAnimation.animationName);
(note: the %n at the end of the message)
System.out.println("Could not load animation: " + rawAnimation.animationName + ". Is it missing?");
Even if 3.x versions are no longer maintained, this is a rather small release so it does not require a lot of effort to do.
The text was updated successfully, but these errors were encountered:
Currently, in Geckolib
3.x
,System.out.printf
is used to emit a warning/error:geckolib/Fabric/core/src/main/java/software/bernie/geckolib3/core/controller/AnimationController.java
Lines 204 to 207 in 6b17247
System.out.printf
will not emit a newline after printing, so you can end up with scenarios where you see something like the following in your logs:Instead, a
Logger
should be use so thatIf, for whatever reason, it is not possible to use a logger, then consider at the very least doing one of the following:
%n
at the end of the message)Even if 3.x versions are no longer maintained, this is a rather small release so it does not require a lot of effort to do.
The text was updated successfully, but these errors were encountered: