Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/node local dns #1603

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Chore/node local dns #1603

merged 4 commits into from
Dec 13, 2024

Conversation

Despire
Copy link
Contributor

@Despire Despire commented Dec 13, 2024

Closes #1425

JKBGIT1
JKBGIT1 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@JKBGIT1 JKBGIT1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
So, we eventually decided to deploy node-local-dns using kubeone, right?

@Despire
Copy link
Contributor Author

Despire commented Dec 13, 2024

So, we eventually decided to deploy node-local-dns using kubeone, right?

Yes

@Despire Despire added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit d6b6f1e Dec 13, 2024
@Despire Despire deleted the chore/node-local-dns branch December 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKBGIT1 JKBGIT1 JKBGIT1 approved these changes

@bernardhalas bernardhalas Awaiting requested review from bernardhalas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Node-local-dns broken
2 participants
@Despire @JKBGIT1