Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload from Components - Not Working .... #534

Open
Asher978 opened this issue Apr 23, 2019 · 6 comments
Open

Hot reload from Components - Not Working .... #534

Asher978 opened this issue Apr 23, 2019 · 6 comments

Comments

@Asher978
Copy link

After a fresh install of this repo and running in dev ...

encountered that the Hot reload is not functioning properly.
For example if I change something in LoginForm and save, I see the below in my console.

image

usage of LoginForm:

// in Login.js (container)
import LoginForm from 'components/LoginForm/LoginForm';

// in routes.js
import Login from 'containers/Login/Loadable';

Any Suggestions?

@bblurock
Copy link

bblurock commented Apr 24, 2019

From what I understand, this is the correct behavior. When rebuilding, WebSocket connection will experience a short downtime.

Also this duplicate with #533

@bertho-zero
Copy link
Owner

This is the normal behavior, the server restarts and the connection is lost for a short time.

@Asher978
Copy link
Author

From what I understand, this is the correct behavior. When rebuilding, WebSocket connection will experience a short downtime.

Also this duplicate with #533

This isn't a duplicate. This issue was related to hot reloading not working properly from components.
The duplicate you referred to #533 is related to sockets connection.

This issue is still unanswered and I would like the issue to be opened again.

@bertho-zero bertho-zero reopened this Apr 24, 2019
@chiragprodsmiths
Copy link

Hi @bertho-zero ,

Thanks for this repo but hot reload is frustrating it doesn't work. any updates on the same

@bertho-zero
Copy link
Owner

I am not very available at the moment but I am open to any PR, do not hesitate to investigate.

@chiragprodsmiths
Copy link

I am not very available at the moment but I am open to any PR, do not hesitate to investigate.

Sure. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants