Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account storage key is not removed during delete #3894

Open
n0izn0iz opened this issue Feb 6, 2022 · 5 comments
Open

Account storage key is not removed during delete #3894

n0izn0iz opened this issue Feb 6, 2022 · 5 comments
Labels
backlog bug type: something isn't working

Comments

@n0izn0iz
Copy link
Contributor

n0izn0iz commented Feb 6, 2022

No description provided.

@n0izn0iz n0izn0iz added the bug type: something isn't working label Feb 6, 2022
@n0izn0iz n0izn0iz changed the title [BUG]: account storage key is removed during delete [BUG]: account storage key is not removed during delete Feb 6, 2022
@aeddi aeddi changed the title [BUG]: account storage key is not removed during delete Account storage key is not removed during delete Jun 21, 2022
@jefft0
Copy link
Collaborator

jefft0 commented Oct 6, 2023

Need to find the key store on iOS. (Maybe look at js/ios/Berty/Sources/Bridge/KeystoreDriver.swift ?)
Should also try to find the keystore on Android. (Maybe look at js/android/app/src/main/java/tech/berty/gobridge/KeystoreDriver.java ?)

@jefft0
Copy link
Collaborator

jefft0 commented Oct 20, 2023

On iOS, handleAppUninstallation calls clearSecureKeyStore(). How to check if this is used when the account is deleted?

self.clearSecureKeyStore()

On Android, where does it create the keystore?

private SharedPreferences getSecureSharedPreferences() throws GeneralSecurityException, IOException {

@jefft0
Copy link
Collaborator

jefft0 commented Oct 27, 2023

We don't have enough info right now to understand how the key store is saving data using the OS features. Put in backlog until we have time to investigate.

@jefft0 jefft0 added the backlog label Oct 27, 2023
@n0izn0iz
Copy link
Contributor Author

I think this issue was about the key not being removed on account delete, not app removal

@jefft0
Copy link
Collaborator

jefft0 commented Oct 27, 2023

Thanks, @n0izn0iz! I updated the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug type: something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants